Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP Exporter: Support IDeferredMeterProviderBuilder in AddOtlpExporter #2413

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

CodeBlanch
Copy link
Member

Changes

Adds support for IOptions<OtlpExporterOptions> in MeterProviderBuilder "AddOtlpExporter" extension .

TODOs

  • CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team September 27, 2021 17:37
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #2413 (6d4738d) into main (52559be) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   80.23%   80.18%   -0.06%     
==========================================
  Files         235      235              
  Lines        7564     7569       +5     
==========================================
  Hits         6069     6069              
- Misses       1495     1500       +5     
Impacted Files Coverage Δ
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 0.00% <0.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

@cijothomas cijothomas merged commit 400e463 into open-telemetry:main Sep 27, 2021
@CodeBlanch CodeBlanch deleted the otlp-deferred branch October 15, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants